Update googlemaps api version to v3.32 #14146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Backend tests are failing, by the way. |
|
retest this please |
|
Hi @ramiroaznar This is ready for acceptance. See STA 🔝 |
|
LGTM, right? |
|
Yes, that's the expected error because of a "made-up" api-key |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #13902
A simple update of the gmaps version, from current 3.30 to 3.32 (which has been already used in carto.js)
Acceptance
gmaps user at staging
<script type="text/javascript" src="//maps.googleapis.com/maps/api/js?v=3.32"></script>Important: as the user doesn't have a valid gmaps api key, the gmaps will NOT BE RENDERED (and there will be javacript errors regarding to invalid key), but the script tag will be there. So this is a little "leap of faith"