Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard] Replace title for items number when selecting in datasets or maps page #14832

Closed
csubira opened this issue Apr 22, 2019 · 4 comments
Assignees

Comments

@csubira
Copy link
Contributor

csubira commented Apr 22, 2019

Context

In maps/datasets page, when clicking on 'Select All' option,

Screen Shot 2019-04-22 at 12 09 33

as @jsanch mentioned in dashboard project channel in slack, it is confusing to know if all your items have been selected or just the ones on the current page.

Current status

Currently when items are selected in maps or datasets page, bulk actions to be applied to the selected items appear next to the title, when scrolling down, on top of the actions, the number or selected items appear next to them:

Screen Shot 2019-04-22 at 12 06 51

Solution

To clear up the confusion, @kukukaka suggested replacing the page title Your maps, Your datasets with the number of selected items as it happens when the sticky bar appears scrolling.

@csubira
Copy link
Contributor Author

csubira commented May 6, 2019

Acceptance done via the following steps:

Login with staging user and go to maps page:

  • On simple map card view: select several maps and check that the number of selected maps appears replacing the title
  • On condensed map card view: select several maps and check that the number of selected maps appears replacing the title
  • Scroll and check that number of selected items works properly in sticky bar
  • Deselect all elements and check that the page title (Your maps) is back

Go to datasets page:

  • Select several maps and check that the number of selected datasets appears replacing the title
  • Scroll and check that number of selected items works properly in sticky bar
  • Deselect all elements and check that the page title (Your datasets) is back

@alejandraarri
Copy link
Contributor

Deployed 🚀 and checked 👌

@alonsogarciapablo
Copy link
Contributor

Nice @alejandraarri 👏👏👏

@jsanch
Copy link

jsanch commented May 11, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants