Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace title when selecting visualizations #14838

Merged
merged 9 commits into from
May 6, 2019
Merged

Replace title when selecting visualizations #14838

merged 9 commits into from
May 6, 2019

Conversation

alejandraarri
Copy link
Contributor

Related issues

#14832

csubira
csubira reviewed Apr 30, 2019
View reviewed changes
Copy link
Contributor

@csubira csubira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks OK! Maybe a small test to check the change when selected datasets?

@alejandraarri alejandraarri requested a review from csubira May 6, 2019 10:02
csubira
csubira approved these changes May 6, 2019
View reviewed changes
Copy link
Contributor

@csubira csubira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks 👌 !

@csubira
Copy link
Contributor

csubira commented May 6, 2019

Acceptance #14832 (comment)

@alejandraarri alejandraarri merged commit 75f5691 into master May 6, 2019
@alejandraarri alejandraarri deleted the 14832-selecting-title branch May 6, 2019 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csubira csubira csubira approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alejandraarri @csubira