-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Organization user login #4026
Comments
@saleiva, are we adding the name of the organization on purpose (in the top of the page)? or you added as part as the logo? |
Is part of the logo |
I'm thinking that the logo should be over white anyway... so I might need to adapt the design a bit... |
I added a text-shadow, just in case background color is light |
That will not work since most of the logos will be pngs or even jpgs. Go ahed with the actual design but we will likely have to change it soon |
👍 |
No, but I thought in the design we had: Logo (image) + organization name (text with shadow) + CartoDB logo (image) But in any case, let's try with this one and then we will revisit it. |
Nope. It's only a logo plus an small logo |
@juanignaciosl, a bug I found, maybe my bad, in that case sorry :S. STR:
undefined local variable or method `login_org_avatar' for #<#<Class:0x000000075cec28>:0x00000009c5d128> |
Look and feel added, but a review together @saleiva would be appreciated. |
@xavijam can't reproduce the error, could you give me more details?
|
Ha! Restarted my development server and working like a charm, so done! :) |
Great, @xavijam , so some testing & merge? :-) |
Yes and no, I have to take a look with @saleiva and then ready to go. |
The text was updated successfully, but these errors were encountered: