Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organization user login #4026

Closed
4 tasks done
xavijam opened this issue Jun 12, 2015 · 14 comments
Closed
4 tasks done

Organization user login #4026

xavijam opened this issue Jun 12, 2015 · 14 comments
Assignees
Labels

Comments

@xavijam
Copy link
Contributor

xavijam commented Jun 12, 2015

@xavijam
Copy link
Contributor Author

xavijam commented Jun 15, 2015

@saleiva, are we adding the name of the organization on purpose (in the top of the page)? or you added as part as the logo?

screen shot 2015-06-15 at 15 45 55

@saleiva
Copy link
Contributor

saleiva commented Jun 15, 2015

Is part of the logo

@saleiva
Copy link
Contributor

saleiva commented Jun 15, 2015

I'm thinking that the logo should be over white anyway... so I might need to adapt the design a bit...

@xavijam
Copy link
Contributor Author

xavijam commented Jun 15, 2015

I added a text-shadow, just in case background color is light

@saleiva
Copy link
Contributor

saleiva commented Jun 15, 2015

That will not work since most of the logos will be pngs or even jpgs. Go ahed with the actual design but we will likely have to change it soon

@xavijam
Copy link
Contributor Author

xavijam commented Jun 15, 2015

👍

@xavijam
Copy link
Contributor Author

xavijam commented Jun 15, 2015

No, but I thought in the design we had:

Logo (image) + organization name (text with shadow) + CartoDB logo (image)

But in any case, let's try with this one and then we will revisit it.

@saleiva
Copy link
Contributor

saleiva commented Jun 15, 2015

Nope. It's only a logo plus an small logo

@xavijam
Copy link
Contributor Author

xavijam commented Jun 15, 2015

@juanignaciosl, a bug I found, maybe my bad, in that case sorry :S.

STR:

  1. Go to login page.
  2. Click login button (yes, leave the password field empty).
  3. Error ->
undefined local variable or method `login_org_avatar' for #<#<Class:0x000000075cec28>:0x00000009c5d128>

@xavijam xavijam assigned juanignaciosl and unassigned xavijam Jun 15, 2015
@xavijam
Copy link
Contributor Author

xavijam commented Jun 15, 2015

Look and feel added, but a review together @saleiva would be appreciated.

@juanignaciosl
Copy link
Contributor

@xavijam can't reproduce the error, could you give me more details?

  • Which url are you using?
  • What username do you set?
  • Full error stack trace.
  • Have you reproduced it in staging?

@xavijam
Copy link
Contributor Author

xavijam commented Jun 15, 2015

Ha! Restarted my development server and working like a charm, so done! :)

@juanignaciosl
Copy link
Contributor

Great, @xavijam , so some testing & merge? :-)

@xavijam
Copy link
Contributor Author

xavijam commented Jun 16, 2015

Yes and no, I have to take a look with @saleiva and then ready to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants