Delete Animated option and add a new Aggregation method

[javisantana]

When style is set as animated some things needs to happen:

• if the style applied does not use any variable it should work like it's working with now
• if we have one style using "by value"
  • if it's a category attribute: torque style should use cdb_mode([attribute]) as aggregation and use the turbocarto for the category
  • if it's a ramp attribute: torque style should use avg([attribute]) as aggregation and use the turbocarto for ramps
• if we have more than one style attribute using "by value" -> we can't do anything with torque here since we don't have multivariable torque <- cc @saleiva. One solution would be to disable animated when this happen but not sure how hard is to explain that limitation to the user.

[javisantana]

cc @xavijam

[saleiva]

When having by value in size and color, we will just keep color. if having
just one, we will keep that one.

@urbanphes we need to edit the component to say "Animated maps only support
one variable by value - or something like that" when this happens.

2016-07-20 16:38 GMT+02:00 javi santana notifications@github.com:

cc @xavijam https://github.com/xavijam

—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
#9010 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAIENajtFfdOHvS03wUUPsl9di32DSMRks5qXjMDgaJpZM4JQ1wy
.

Sergio Alvarez Leiva

[javisantana]

@xavijam I'm going to do the style generation part

[xavijam]

Ok!, but design is needed right?

[javisantana]

yes, there are two parts of this issue:

• style generation <- me
• UI changes <- design team and you

[urbanphes]

From the UI;

• Delete the animated check in all parts.
  
  
  
  
  
  
• Add new aggregation method ANIMATED (with its configuration)
  
  
  
  
  
  
  cc/ @saleiva @javisantana @xavijam

[javisantana]

dios os quiere

[saleiva]

Top priority since this can help with
#9097
#9100

And many more...

[xavijam]

This will need migration changes from old editor to new one, cc @juanignaciosl.

[nobuti]

In order to cluster all the animated types under the same aggregation, we need to segment the type (heatmap or pixel):

Note that TYPE selector changes whatever fields it needs.

[xavijam]

Further to torque categories, I've tried what @javisantana proposed but I can't make it work. After a talk with @rochoa, that cdb_mode thing should use CDB_Math_Mode, but in any case it doesn't take into account the ramp color, it just take the first one. The thing I've tried is:

Map {
  -torque-frame-count: 172;
  -torque-animation-duration: 60;
  -torque-time-attribute: "cartodb_id";
  -torque-aggregation-function: "CDB_Math_Mode(category_n)";
  -torque-resolution: 4;
  -torque-data-aggregation: linear;
}
#layer {
  marker-width: 7;
  marker-fill: ramp([category_n], (blue, yellow, red)); // category_n -> strings
  marker-allow-overlap: true;
  marker-line-width: 1;
  marker-line-color: #fff;
  marker-line-opacity: 1;
}
#layer[frame-offset=1] {
  marker-width: 9;
  marker-fill-opacity: 0.5;
}
#layer[frame-offset=2] {
  marker-width: 11;
  marker-fill-opacity: 0.25;
}

[rochoa]

Avoid using // comment style.

What torque.js version are you using?

[xavijam]

I added the comment in the code above, not in the real CartoCSS.
Torque version 2.15.1 (from npm module).