Upgrade to google-client-api 0.28.4

[ethervoid]

Related #14696

We need to upgrade it because it fails with ruby 2.4.x

[gonzaloriestra]

Wow, more changes than I was expecting... Nice work! 💪

We should have more tests (coverage seems to be quite poor here) and code could be cleaner also (smaller methods, more descriptive variable names...), but I guess it would be to ask too much for an unexpected task like this 😅

We'll have to test it very carefully.

[ethervoid]

Don't be shy, ask for all changes needed. I've done it in a rush but that is not excuse to have it cleaner or improved El lun., 25 feb. 2019 19:18, Gonzalo Riestra <notifications@github.com> escribió:

…

***@***.**** approved this pull request. Wow, more changes than I was expecting... Nice work! 💪 We should have more tests (coverage seems to be quite poor here) and code could be cleaner also (smaller methods, more descriptive variable names...), but I guess it would be to ask too much for an unexpected task like this 😅 We'll have to test it very carefully. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#14683 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAtPeJOUHWnQm948DR8MTGVKWNWuzC4Xks5vRCjygaJpZM4bFsem> .

[gonzaloriestra]

I've tested it in the dedicated instance you have created, but I couldn't import any file from 2 different Google accounts, while those files do work in production.

It says: Unknown (99999). Sorry, something went wrong and we're not sure what. Try uploading your file again, or contact us and we'll try to help you quickly.

https://rollbar.com/carto/CartoDB/items/8/

[gonzaloriestra]

Acceptance:

• Drive, Box, Dropbox and ArcGIS connectors (connection, file listing, importing and revoke)
• CSV, XLS, SHP and Zip file types with Drive
• Listing of Drive account with more than 440 files (limited to that number)
• Shared files in Drive
• Single and multilayer imports
• Synchronizations
• Repeat the tests using ruby 2.2 to check backward compatibility

[ethervoid]

@gonzaloriestra I didn't answer properly to the test part. We can't have tests because this is a third party library use so we should test the integration but for that, we need to have an oauth app + authentication...and that is going to be open in the repository so...

[jgoizueta]

I've been testing this branch with Ruby 2.2 in a dedicated staging host.

Everything's fine, except we'll need to wait for an hour to see if the synchronization updates correctly.

• Drive, Box, Dropbox and ArcGIS connectors (connection, file listing, importing and revoke)
• CSV, XLS, SHP and Zip file types with Drive
• Listing of Drive account with more than 440 files (limited to that number)
• Shared files in Drive
• Single and multilayer imports
• Synchronizations

[jgoizueta]

Synchronizations update correctly