-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Signup fields III] Profile form #14966
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Jun 12, 2019
lib/assets/javascripts/dashboard/views/profile/profile-form/profile-form-view.js
Outdated
Show resolved
Hide resolved
retest this please |
alrocar
reviewed
Jun 14, 2019
alrocar
approved these changes
Jun 14, 2019
retest this please |
Acceptance 💚 ❓ Everything seems to be ok, in cartodb, central and dbs, but in all cases, I have received a 504 error (gateway timeout) by nginx in the account creation. I suppose, this is happening in master too and it is not due to these changes. |
It is happening (504 error) with Acceptance 💚 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to CartoDB/product#337
Added the new fields to the user profile and enabled synchronization with central.