Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "Professional" Plan to "Individual" Plan #15069

Merged
merged 9 commits into from
Sep 10, 2019
Merged

Conversation

csubira
Copy link
Contributor

@csubira csubira commented Aug 22, 2019

#15067

This is part of a bigger issue. Please DO NOT MERGE since it's part of this.

@csubira csubira assigned alrocar and unassigned alrocar Aug 22, 2019
@csubira csubira requested a review from alrocar August 22, 2019 15:02
@@ -91,10 +91,10 @@ module.exports = CoreView.extend({
},

_canChangePrivacy: function (privacy) {
var isPro2019User = this.options.userModel.isPro2019User();
var isIndividualUser = this.options.userModel.isIndividualUser();
Copy link
Contributor

@alejandraarri alejandraarri Aug 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better naming!! 😄

Copy link
Contributor

@alejandraarri alejandraarri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@alrocar alrocar removed their request for review August 23, 2019 12:09
@alrocar alrocar merged commit 276ddf1 into master Sep 10, 2019
@alrocar alrocar deleted the 15067-pro-to-individual branch September 10, 2019 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants