Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kuviz has unique name #15385

Merged
merged 12 commits into from
Jan 16, 2020
Merged

kuviz has unique name #15385

merged 12 commits into from
Jan 16, 2020

Conversation

simon-contreras-deel
Copy link
Contributor

Solves a part of: CartoDB/cartoframes#1451

gonzaloriestra
gonzaloriestra suggested changes Jan 13, 2020
View reviewed changes
Copy link
Contributor

@gonzaloriestra gonzaloriestra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! ❤️

The main thing would be to move the validation to the model. The rest are just suggestions.

app/controllers/carto/api/public/custom_visualizations_controller.rb Outdated Show resolved Hide resolved
app/controllers/carto/api/public/custom_visualizations_controller.rb Outdated Show resolved Hide resolved
app/controllers/carto/api/public/custom_visualizations_controller.rb Outdated Show resolved Hide resolved
app/controllers/carto/api/public/custom_visualizations_controller.rb Outdated Show resolved Hide resolved
spec/requests/carto/api/custom_visualizations_controller_spec.rb Outdated Show resolved Hide resolved
@simon-contreras-deel
Copy link
Contributor Author

After working in the client, I realized I must change the default behavior:

  • create: if exists a kuviz with the same name: fail
  • update: if exists a kuviz with the same name: replace

@simon-contreras-deel
Copy link
Contributor Author

I added the not merge yet because we need to merge things in CARTOframes and carto-python before this one

gonzaloriestra
gonzaloriestra approved these changes Jan 14, 2020
View reviewed changes
Copy link
Contributor

@gonzaloriestra gonzaloriestra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@simon-contreras-deel simon-contreras-deel mentioned this pull request Jan 14, 2020
Merged
@simon-contreras-deel
Copy link
Contributor Author

Sorry @gonzaloriestra we have a last minute requirement change CartoDB/cartoframes#1451 (comment) can you please check the last commit?

@gonzaloriestra
Copy link
Contributor

LGTM 👍

@simon-contreras-deel simon-contreras-deel merged commit de72bab into master Jan 16, 2020
@simon-contreras-deel simon-contreras-deel deleted the feature/kuviz-name-unique branch January 16, 2020 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gonzaloriestra gonzaloriestra gonzaloriestra approved these changes

Assignees
No one assigned
Labels
do not merge yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@simon-contreras-deel @gonzaloriestra