-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kuviz has unique name #15385
kuviz has unique name #15385
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! ❤️
The main thing would be to move the validation to the model. The rest are just suggestions.
app/controllers/carto/api/public/custom_visualizations_controller.rb
Outdated
Show resolved
Hide resolved
app/controllers/carto/api/public/custom_visualizations_controller.rb
Outdated
Show resolved
Hide resolved
app/controllers/carto/api/public/custom_visualizations_controller.rb
Outdated
Show resolved
Hide resolved
app/controllers/carto/api/public/custom_visualizations_controller.rb
Outdated
Show resolved
Hide resolved
spec/requests/carto/api/custom_visualizations_controller_spec.rb
Outdated
Show resolved
Hide resolved
After working in the client, I realized I must change the default behavior:
|
I added the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
Sorry @gonzaloriestra we have a last minute requirement change CartoDB/cartoframes#1451 (comment) can you please check the last commit? |
LGTM 👍 |
Solves a part of: CartoDB/cartoframes#1451