Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance for dependent visualizations #15632

Merged
merged 7 commits into from
Apr 30, 2020

Conversation

gonzaloriestra
Copy link
Contributor

@gonzaloriestra gonzaloriestra commented Apr 29, 2020

Related to https://github.com/CartoDB/cartodb-platform/issues/6446

Calculate dependent visualizations with one single SQL query instead of AR with prefetch + Ruby. It looks like it's around 7 times faster now when having many dependencies.

For the acceptance, this user has a few datasets with ~500 maps. Besides checking the performance, we should ensure it properly calculates them: avoiding duplicates, taking into account maps with multiple layers, showing the right metadata...

Copy link
Contributor

@simon-contreras-deel simon-contreras-deel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gonzaloriestra
Copy link
Contributor Author

I've finally reduced the scope to avoid collateral damage and protected it under a new feature flag: faster-dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants