Improve performance for dependent visualizations #15632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simon-contreras-deel
force-pushed
the
improve-dependent-visualizations
branch
from
0ae3819
to
fb2b5f9
Compare
|
I've finally reduced the scope to avoid collateral damage and protected it under a new feature flag: |
simon-contreras-deel
approved these changes
Apr 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to https://github.com/CartoDB/cartodb-platform/issues/6446
Calculate dependent visualizations with one single SQL query instead of AR with prefetch + Ruby. It looks like it's around 7 times faster now when having many dependencies.
For the acceptance, this user has a few datasets with ~500 maps. Besides checking the performance, we should ensure it properly calculates them: avoiding duplicates, taking into account maps with multiple layers, showing the right metadata...