Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Db Direct firewall operations #15641

Merged
merged 9 commits into from
May 4, 2020
Merged

Db Direct firewall operations #15641

merged 9 commits into from
May 4, 2020

Conversation

jgoizueta
Copy link
Member

Firewall rule management was performed by deleting/creating new rules for every change. The logic for it was to eventually restore inconsistencies between the rules and the metadata, but combining two operations (destroy & create) while using a "fire and forget" approach to avoid blocking the process proved to be problematic (the create could end up being executed before the destroy was effective).

This changes firewall management to perform always single operations

@jgoizueta jgoizueta merged commit ff1c8a8 into master May 4, 2020
@jgoizueta jgoizueta deleted the dbdirect-firewall-ops branch May 4, 2020 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants