Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make DB Direct certificates server_ca configurable #15650

Merged
merged 6 commits into from
May 6, 2020

Conversation

jgoizueta
Copy link
Member

So far, in development, the server_ca certificate has been fetch from the CA used to sign client certificates, but in production we need to control what should be in it or if it should be disabled (e.g. for server certificates signed by CA for which all systems include their root certificates).

So I've added a new configuration parameter dbdirect.certificates.server_ca to control this.

  • If it's not defined we preserve the current behaviour, which can also be selecte withe the special client_ca value (for convenience of chef-controlled configurations)
  • The special value disabled prevents inclusion of server_ca with client certificates and omits also references to it in the README.
  • Otherwise it should contain a URL accessible to download the server_ca file.

Copy link
Contributor

@gonzaloriestra gonzaloriestra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about some tests?

lib/carto/dbdirect/certificate_manager.rb Outdated Show resolved Hide resolved
lib/carto/dbdirect/certificate_manager.rb Show resolved Hide resolved
Co-authored-by: Gonzalo Riestra <gonzalor@cartodb.com>
@jgoizueta
Copy link
Member Author

Regarding the tests: unfortunately, CertificateManager has no CI tests at all: it relies heavily on AWS services. Given the current workload I'd rather not get into this; I feel confident with the local tests I've performed.

@jgoizueta jgoizueta merged commit 3c2106a into master May 6, 2020
@jgoizueta jgoizueta deleted the dbdirect-server_ca branch May 6, 2020 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet

2 participants