-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Temporary change for the new BQ connector #16029
Temporary change for the new BQ connector #16029
Conversation
This is needed until new Connections are merged in
…e/ch122137/deploy-new-bigquery-connector
project | Defines the Google Cloud project that contains the data to be imported (optional). | ||
dataset | Name of the dataset to import data from (optional). | ||
table \| sql_query | Required. Either identify the BigQuery table to be imported or use a SQL query to fetch data. | ||
import_as | Can be used to specifiy the name of the imported dataset (optional) | ||
storage_api | (true/false) specifies if BigQuery Storage API will be used or not. (optional; false by default) | ||
|
||
Note that you could either import from a query using `sql_query` or from a table using `table`. | ||
Note also that by default the Storage API is not used. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this sentence
lib/carto/connector.rb
Outdated
@@ -15,6 +15,7 @@ def initialize(parameters:, user:, **args) | |||
@provider_name ||= DEFAULT_PROVIDER | |||
|
|||
@user = user | |||
temporay_parameters_adjustment_for_new_bigquery_connector |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a big deal, but there is a typo in "temporay"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This is needed until new Connections are merged in.
See https://app.clubhouse.io/cartoteam/story/122137