Temporary change for the new BQ connector #16029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed until new Connections are merged in
jgoizueta
changed the base branch from
master
to
feature/ch122137/rename-bigquery-connector
…e/ch122137/deploy-new-bigquery-connector
borja-munoz
reviewed
Jan 13, 2021
| project | Defines the Google Cloud project that contains the data to be imported (optional). | ||
| dataset | Name of the dataset to import data from (optional). | ||
| table \| sql_query | Required. Either identify the BigQuery table to be imported or use a SQL query to fetch data. | ||
| import_as | Can be used to specifiy the name of the imported dataset (optional) | ||
| storage_api | (true/false) specifies if BigQuery Storage API will be used or not. (optional; false by default) | ||
|
|
||
| Note that you could either import from a query using `sql_query` or from a table using `table`. | ||
| Note also that by default the Storage API is not used. |
borja-munoz
reviewed
Jan 13, 2021
lib/carto/connector.rb
Outdated
| @@ -15,6 +15,7 @@ def initialize(parameters:, user:, **args) | |||
| @provider_name ||= DEFAULT_PROVIDER | |||
|
|
|||
| @user = user | |||
| temporay_parameters_adjustment_for_new_bigquery_connector | |||
There was a problem hiding this comment.
Not a big deal, but there is a typo in "temporay"
Base automatically changed from
feature/ch122137/rename-bigquery-connector
to
master
January 14, 2021 13:19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed until new Connections are merged in.
See https://app.clubhouse.io/cartoteam/story/122137