Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: modify deprecation warning for DO analysis in builder #16163

Merged
merged 3 commits into from
Feb 18, 2021

Conversation

VictorVelarde
Copy link
Contributor

From 2021-03-15 to 2021-03-31

@VictorVelarde VictorVelarde merged commit 4639484 into master Feb 18, 2021
@VictorVelarde VictorVelarde deleted the modify-do-v1-deprecation branch February 18, 2021 11:47
@rafatower
Copy link
Contributor

🤖 please make sure all the checks pass before merging @VictorVelarde @Josmorsot

@VictorVelarde
Copy link
Contributor Author

VictorVelarde commented Mar 4, 2021

Thx @rafatower, I'm sorry for this one.

I have reviewed the PR and honestly I'm not sure about the reason of the failure. It indicates an issue like: "Step #9: createdb: error: database creation failed: ERROR: database "template_postgis" already exists". And internally the issue says:

Step #9: Failures:
Step #9: 
Step #9:   1) Carto::Api::VisualizationsController index ordering orders by favorited
Step #9:      Failure/Error: collection[0]['id'].should eq visualization_a.id
Step #9:        
Step #9:        expected: "829dd067-5bd7-4755-bf8b-6001881c7bc8"
Step #9:             got: "5932458c-5c83-4d60-94f1-eae4426c9c68"
Step #9:        
Step #9:        (compared using ==)
Step #9:      # ./spec/requests/carto/api/visualizations_controller_index_spec.rb:258:in `block (4 levels) in <top (required)>'
Step #9: 
Step #9: Finished in 6 minutes 18.69 seconds
Step #9: 127 examples, 1 failure, 1 pendin

I guess that in this case, I should have just retried the GCP build, right?

@VictorVelarde
Copy link
Contributor Author

VictorVelarde commented Mar 4, 2021

I will appreciate if this check is becoming mandatory now. I would also appreciate a theory on what could happened here with that process and test (@thedae, when you have time for a small comment...).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants