-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
some fixes to cartodb ci #16179
Merged
Merged
some fixes to cartodb ci #16179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8648cc6
to
33f8ba3
Compare
This pull request has been linked to Clubhouse Story #137764: Fix cartodb backend tests. |
46875b8
to
83cfc60
Compare
rafatower
approved these changes
Feb 26, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just left a one-line change request
Thanks!
🤖 please make sure all the checks pass before merging @ibrahimmenem |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://app.clubhouse.io/cartoteam/story/137764/fix-cartodb-backend-tests
Now we will upload 3 log files to https://console.cloud.google.com/storage/browser/cartodb-ci-tmp-logs/test_logs_{BUILD_ID}
Logs of parallel tests:
test_logs_${BUILD_ID}/parallel_tests_logs
test_logs_${BUILD_ID}/docker_compose_logs
Logs of second try:
test_logs_${BUILD_ID}/serial_tests_logs
the log files will be available for 1 day, then automatically deleted