Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix named maps API retries + temporarily silence logging #16190

Merged
merged 3 commits into from
Mar 5, 2021

Conversation

thedae
Copy link
Contributor

@thedae thedae commented Mar 4, 2021

No description provided.

@thedae thedae requested a review from rafatower March 4, 2021 12:25
Copy link
Contributor

@rafatower rafatower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please consider turning the error into a warning, but honestly I think the fix is enough to save many traces

@@ -190,7 +190,7 @@ def log_response(response, action)
# Hotfix for preventing https://rollbar.com/carto/CartoDB/items/41457 until we find the root cause
# https://cartoteam.slack.com/archives/CEQLWTW9Z/p1599134417001900
# https://app.clubhouse.io/cartoteam/story/101908/fix-encoding-error-while-logging-request
Rollbar.error(e)
# Rollbar.error(e)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you want to actually silence errors, you have to turn the log_error above into a log_warning at line 180

https://github.com/CartoDB/cartodb/pull/16190/files#diff-85c80f4b786ac68618c0598445c7712a3e622b9ff1eb4d31ef60eb2b29674256R180

log_error logs to both stdout/err and rollbar

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, I missed that

Thanks!

@thedae thedae merged commit 46b34d9 into master Mar 5, 2021
@thedae thedae deleted the chore/named-maps-api-tweaks branch March 5, 2021 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants