Fix free users can't create datasets due to default state was private #16223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Clubhouse Story #138033: [Free-Academic users] Invalid import when using the UI. |
added 3 commits
March 17, 2021 13:19
…8033/free-academic-users-invalid-import-when-using
| @@ -11,3 +11,4 @@ export const accountsWithApiKeysLimitsToZero = free2020; | |||
|
|
|||
| export const accountsWithDataCatalogLimits = [...free2020, ...free, ...student]; | |||
| export const accountsWithOauthAppsLimits = [...free2020, ...free, ...student]; | |||
| export const accountsWithDefaultPublic = [...free2020, ...free, ...student]; | |||
There was a problem hiding this comment.
Looks like a better approach, 👍🏻
VictorVelarde
changed the title
lib/assets/javascripts/new-dashboard/mixins/connector/uploadData.js
Outdated
Show resolved
Hide resolved
|
LGTM, are you deploying a staging for acceptance? |
jgoizueta
approved these changes
Mar 17, 2021
There was a problem hiding this comment.
LGTM
Sorry for the delay, it took me too long to verify the behaviour of the import backend when the privacy parameter is not present.
If the privacy parameter is blank/missing the backend will do the proper thing: default to private for users with private tables and public otherwise. So if you prefer to always omit the parameter, that would be fine too.
added 3 commits
March 31, 2021 17:57
…8033/free-academic-users-invalid-import-when-using
Josmorsot
deleted the
feature/ch138033/free-academic-users-invalid-import-when-using
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://app.clubhouse.io/cartoteam/story/138033/free-academic-users-invalid-import-when-using-the-ui
Summary:
Free users were trying to import datasets, by default we had privacy as
PRIVATEbut they can't import private datasets