Cache vizjson in redis to avoid hitting DB #2324 #2194
Conversation
|
Frontend tests were OK 👍 (details) |
|
Frontend tests were OK 👍 (details) |
|
Frontend tests were OK 👍 (details) |
|
Frontend tests were OK 👍 (details) |
rafatower
changed the title
|
Frontend tests were OK 👍 (details) |
|
@javisantana review please. A few notes:
|
| end | ||
|
|
||
| describe '#redis_cached' do | ||
| it "Uses the block given to calculate a hash if there's a cache miss" do |
There was a problem hiding this comment.
@Kartones as a curiosity, this is how I solved the called block problem
|
Frontend tests were OK 👍 (details) |
|
@rochoa can you please review? |
|
retest this, please |
| @@ -20,7 +20,8 @@ | |||
| tables_metadata: 0, | |||
| api_credentials: 3, | |||
| users_metadata: 5, | |||
| redis_migrator_logs: 6 | |||
| redis_migrator_logs: 6, | |||
| visualizations: 7, | |||
There was a problem hiding this comment.
Are we using another database for this? 😈
I understand how this can be useful, but unfortunately I consider
Redis multiple database errors my worst decision in Redis design at
all... without any kind of real gain, it makes the internals a lot
more complex. The reality is that databases don't scale well for a
number of reason, like active expire of keys and VM. If the DB
selection can be performed with a string I can see this feature being
used as a scalable O(1) dictionary layer, that instead it is not.
https://groups.google.com/forum/#!msg/redis-db/vS5wX8X4Cjg/8ounBXitG4sJ
|
Frontend tests were OK 👍 (details) |
|
OK for me 👍 although I would try to avoid using an extra database for this. |
|
Ok, I'll move it to |
|
I agree with you on the naming issue but that's easier to fix than having to migrate another database in the future (yes, I know probably we won't migrate to just one database anytime soon but better to avoid making this the standard). |
As discussed in peer review, using a new redis db should not be the standard for new code. See https://groups.google.com/forum/#!msg/redis-db/vS5wX8X4Cjg/8ounBXitG4sJ
|
Frontend tests were OK 👍 (details) |
Cache vizjson in redis to avoid hitting DB #2324
Ready to be merged