Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix copy on delete items dialog #2410

Merged
merged 3 commits into from
Feb 20, 2015
Merged

Fix copy on delete items dialog #2410

merged 3 commits into from
Feb 20, 2015

Conversation

viddo
Copy link
Contributor

@viddo viddo commented Feb 20, 2015

Fixes #2392

screen shot 2015-02-20 at 17 00 49

Fixes #2385

screen shot 2015-02-20 at 17 14 32
screen shot 2015-02-20 at 17 15 02

@viddo
Copy link
Contributor Author

viddo commented Feb 20, 2015

cc @saleiva

Fixes #2385
5d4a202 
Unify title in change privacy dialog to match delete items
@viddo
Copy link
Contributor Author

viddo commented Feb 20, 2015

cc @piensaenpixel

@Cartofante
Copy link
Collaborator

Frontend tests were OK 👍 (details)

@viddo
Copy link
Contributor Author

viddo commented Feb 20, 2015

FYI @xavijam

viddo added a commit that referenced this pull request Feb 20, 2015
@viddo
Merge pull request #2410 from CartoDB/2392-fix-delete-items-subtitle
490eb53 
Fix copy on delete items dialog
@viddo viddo merged commit 490eb53 into master Feb 20, 2015
@viddo viddo deleted the 2392-fix-delete-items-subtitle branch February 20, 2015 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect text on delete map modal Remove name of maps
2 participants
@viddo @Cartofante