Remove specs for cached vizjson that was removed #2486
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I guess someone of you, @Kartones @juanignaciosl @rafatower , is most suitable to review the changes |
|
Frontend tests were OK 👍 (details) |
|
cc @javisantana |
|
Hey @viddo , please don't remove them. @rafatower will disable them (just adding |
|
Fair enough, will he do it on this PR or should I just close it? |
|
keep it and I'll reuse this ticket if you don't mind |
|
For me totally fine, go ahead :) |
|
fixed in #2487 instead |
|
Frontend tests were OK 👍 (details) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 2 tests fail on master atm, due to 83ba1a2 (hotfix on master) I think it makes sense to remove those the failing tests that asserts the cache.