Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add loading+error state for privacy dialog #2484

Merged
merged 7 commits into from
Feb 25, 2015

Conversation

viddo
Copy link
Contributor

@viddo viddo commented Feb 24, 2015

Fixes #2340

The previous approach, of using the tab pane, was not very suitable for this use-case which became painfully clear when trying to accommodate the new saving and error states. So, instead I've replaced it with the same approach as done in the other dialogs, i.e. a view model to encapsulate the view logic.

privacy-loading

Also:

Nicklas Gummesson added 2 commits February 24, 2015 19:39
Extracted logic to a view model instead, for easier testing and
maintenance
@viddo
Copy link
Contributor Author

viddo commented Feb 24, 2015

ping @xavijam @saleiva code review etc. (see description for rationale and scope)

@xavijam
Copy link
Contributor

xavijam commented Feb 25, 2015

Check tests :), apart from that, go ahead 👍.

@viddo
Copy link
Contributor Author

viddo commented Feb 25, 2015

Backend tests, fix on the way here --> #2486

@Cartofante
Copy link
Collaborator

Frontend tests were OK 👍 (details)

viddo added a commit that referenced this pull request Feb 25, 2015
…-states

Add loading+error state for privacy dialog
@viddo viddo merged commit 50abeac into master Feb 25, 2015
@viddo viddo deleted the 2340-privacy-dialog-loading-err-states branch February 25, 2015 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants