Set higher contrast for nav buttons #2696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping @saleiva @carlostallon, and @xavijam for CSS changes. Btw, if these buttons are considered to have low contrast you should probably review other components that have the same color, no? |
|
It really depends on the size of the elements. I'd merge this and see if we detect anything else later |
|
Sounds good, yeah, I was going to suggest to create new issues in that case, just wanted to make sure you were aware 👍 |
|
bump, good to go? |
viddo
added a commit
that referenced
this pull request
Mar 11, 2015
Set higher contrast for nav buttons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2429
Default color is now
#BBB, and#888on hover, e.g.: