Position map overlays properly when there is a SQL header banner #2762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When map overlays was split out from mapview at least one variable (this.headerMessageIsVisible) wasn’t migrated with the rest, so the check for the SQL header have been missing since. Also, the search overlay was not poisoned properly (improper calls).
|
@javierarce code review please |
:tmcw: |
|
👍 |
|
@javisantana relatively speaking ofc 💋 |
|
👍 I would only change:
|
|
@javierarce agree, done |
|
looks beautiful to me 👍 |
|
Frontend tests were OK 👍 (details) |
viddo
added a commit
that referenced
this pull request
Mar 16, 2015
Position map overlays properly when there is a SQL header banner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2683
When map overlays was split out from mapview at least one variable (this.headerMessageIsVisible) wasn’t migrated with the rest, so the check to re-position overlays could not have been working since then. Also, the search overlay position calls were not correct either.
Anyway, this is the "quick fix". Adding tests for this was extremely hard (there didn't exist none), so finally skipped it since I don't think it's worth it right now. The code related to these parts are extremely and overly complicated (especially since most of it could be replaced with some proper CSS). Having in mind that we inevitably will touch this again when doing the redesign of the editor I propose to deal with it then instead.