2660 extract storage take4 #2775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
March 10, 2015 16:02
|
Frontend tests were OK 👍 (details) |
| @@ -217,7 +217,7 @@ def public_map | |||
| @user_domain = user_domain_variable(request) | |||
|
|
|||
| @public_tables_count = @visualization.user.public_table_count | |||
| @nonpublic_tables_count = @related_tables.select{|p| p.privacy != ::Table::PRIVACY_PUBLIC }.count | |||
| @nonpublic_tables_count = @related_tables.select{|p| p.privacy != ::UserTable::PRIVACY_PUBLIC }.count | |||
There was a problem hiding this comment.
I think you forgot changing this check as you've done in the following lines.
|
Frontend tests were OK 👍 (details) |
|
Frontend tests were OK 👍 (details) |
|
Frontend tests were OK 👍 (details) |
This was referenced Mar 16, 2015
|
retest this, please |
|
Frontend tests were OK 👍 (details) |
|
retest this, please |
|
Frontend tests were OK 👍 (details) |
|
Frontend tests were OK 👍 (details) |
rafatower
changed the title
|
Frontend tests were OK 👍 (details) |
rafatower
pushed a commit
that referenced
this pull request
Mar 18, 2015
2660 extract storage take4 [in testing]
rafatower
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another version, without access to user_table.
table.user_table.*is no longer permitted.This was done to avoid exposing functionality of the model through the
Tableservice/decorator/façade, as Nacho suggested. Why? I tried two different approaches:Table. Almost imposible because of the richness of theSequel::Model,Sequel::Datasetand related classes.UserTableas dumb and ignorant as possible. Not fully possible, cause many business rules are implemented through hooks.UserTablefunctionality directly to client classes. Although it sounded like a good idea at first, this way it is hard to enforce certain business rules (such as setting a table name) without a complex interaction betweenTableandUserTable.So finally this is the best design I could come up having something working.
If I were to refactor this again, I'd probably take a different approach: do not try to fully isolate the model but extract pieces of functionality little by little and assuming the
Modelwould still be the "director" of the interactions. Start with value objects and continue with a UserData service or similar.Cc'ing @Kartones @juanignaciosl and @javisantana so that you have something funny to review when you get to work on Monday :)
Have a nice weekend!