Avoid infinite recursion when renaming #3326 #3330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See the ticket for more info.
|
|
||
| unless errored | ||
| if @user_table.layers.blank? | ||
| exception_to_raise = CartoDB::TableError.new("Attempt to rename table without layers #{qualified_table_name}") |
There was a problem hiding this comment.
I'd either change to raise error (as we're not launching/raising an exception), or as you told me in person, directly remove this par of the if and let the code explode and/or be treated at upper layers if layers are empty.
|
Frontend tests were OK 👍 (details) |
|
👍 Apart from that |
|
Frontend tests were OK 👍 (details) |
rafatower
force-pushed
the
3326-avoid-infinite-recursion-when-renaming
branch
from
2e1d70e
to
21224cc
Compare
|
I tested 2e1d70e but in the end I prefer to keep the |
|
Frontend tests were OK 👍 (details) |
rafatower
pushed a commit
that referenced
this pull request
Apr 23, 2015
…hen-renaming Avoid infinite recursion when renaming #3326
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the ticket for more info.
@Kartones please review