Remove api_key requirement for data library #3506 #3523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Frontend tests were OK 👍 (details) |
|
@javisantana quick CR? Nacho seems having trouble with connectivity. |
|
🇪🇸 |
|
update de app_config.yml.example please |
| from meta_dataset, meta_category | ||
| where meta_dataset.meta_category_id = meta_category.cartodb_id | ||
| query | ||
| DATASETS_QUERY = "SELECT * FROM CDB_CommonDataCatalog();" |
There was a problem hiding this comment.
I'd list used columns, * is error prone and doesn't document what will be returned. Since it's going to be processed manually I think this is a must.
|
Sorry for the delay. I'd really avoid the usage of |
|
Frontend tests were OK 👍 (details) |
|
Frontend tests were OK 👍 (details) |
|
I've taken your comments into acount plus added the removal of the rollbar debug message in c15322d |
|
Ok, great. Warn about that message removal in #technology channel when it's deployed so people don't get scared. |
|
Frontend tests were OK 👍 (details) |
|
Frontend tests were OK 👍 (details) |
rafatower
pushed a commit
that referenced
this pull request
May 6, 2015
Remove api_key requirement for data library #3506
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to CartoDB/data-services#137
@juanignaciosl please review