Mailchimp decorator enables corresponding category wizard and legends #3874
Conversation
| @@ -164,13 +164,23 @@ def get_presenter(options, configuration) | |||
| CartoDB::Layer::Presenter.new(self, options, configuration) | |||
| end | |||
|
|
|||
| def set_style_options(cartocss_style) | |||
| def set_style_options(cartocss_style, opts = {}) | |||
There was a problem hiding this comment.
These 3 methods are only being used by the MailchimpDecorator. I'd be happy to create a more generic method like set_option(name, value) and do something like layer.set_option('tile_style', cartocss) from the MailchimpDecorator. Thoughts?
There was a problem hiding this comment.
definetly yes!
I just added that as a first approach as current Layer model is quite barebones (as frontend JS is usually who controls layer data), so any addition is more than welcome!
|
Frontend tests were OK 👍 (details) |
|
Frontend tests were OK 👍 (details) |
|
Frontend tests were OK 👍 (details) |
|
👍 |
|
Frontend tests were OK 👍 (details) |
|
Thanks @Kartones. Please take a look at this commit that introduces |
Mailchimp decorator enables corresponding category wizard and legends
Fixes #3826.
@Kartones can you please take a look? I added some inline comments. Thanks!