-
Notifications
You must be signed in to change notification settings - Fork 655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Possibility to save all map layers at the same time #4251
Possibility to save all map layers at the same time #4251
Conversation
So, with the current changes the request works correctly but:
|
Frontend tests were OK 👍 (details) |
Frontend tests were OK 👍 (details) |
} | ||
} | ||
); | ||
this.save(null, opts); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since save
is also a one-liner, we could move its code here instead of adding a new public method.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Totally agree, but we still have the problem with the "invalidation" of the tiles when save is completed.
Hi @xavijam @alonsogarciapablo @Cartofante , this issue is happening still for S/B 5831712 Think you guys already got this part, but: Expected:
Happening (in Chrome 43.0.2357.134):
Replicated here:
Polygon layer shows at bottom of Map View layer stack but polygons are still on top of other line and point layers: |
…_save_all_map_layers_at_the_same_time
…_save_all_map_layers_at_the_same_time
…ll_map_layers_at_the_same_time
Frontend tests were OK 👍 (details) |
Frontend tests were OK 👍 (details) |
I think this is now ready and working! 😌 @xavijam Could you PTAL? Thanks! |
Looks great man :) |
…_save_all_map_layers_at_the_same_time
Frontend tests were OK 👍 (details) |
Frontend tests were OK 👍 (details) |
…p_layers_at_the_same_time Possibility to save all map layers at the same time
\o/ :dancer: :grapes: |
Frontend tests were OK 👍 (details) |
Deployed and working 👍. Great job guys! |
Yahoo! :-) |
Basically we have a problem when we need to save the state of all layers those belong to a visualization.
We used to sent as many PUTs as layers we have in the visualization. From now on, we want to just make a request with the needed info.
Fixes #4016.
@juanignaciosl