-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels on top #4286
Labels on top #4286
Conversation
Frontend tests were OK 👍 (details) |
Frontend tests were OK 👍 (details) |
@@ -267,9 +267,9 @@ def admits_more_torque_layers? | |||
torque_layers.length >= 1 && is_table_visualization? ? false : true | |||
end | |||
|
|||
# TODO: We need to allow more than one `tiled` layer now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Frontend tests were OK 👍 (details) |
Frontend tests were OK 👍 (details) |
Frontend tests were OK 👍 (details) |
@@ -466,32 +472,6 @@ cdb.admin.Layers = cdb.geo.Layers.extend({ | |||
saveLayer(layers.at(count)); | |||
}, | |||
|
|||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
layers
have an order
attribute, which is updated every time a new layer is added to the collection. Unless I'm missing something, I think we can get rid of this custom reset
and assume layers are ordered.
Frontend tests were OK 👍 (details) |
Frontend tests were OK 👍 (details) |
Frontend tests were OK 👍 (details) |
Frontend tests were OK 👍 (details) |
…ther than `Tiled`
Frontend tests were OK 👍 (details) |
…dropped. This way the order of layers gets re-calculated correctly.
Frontend tests were OK 👍 (details) |
Frontend tests were OK 👍 (details) |
This should be now ready to be merged! \o/ @xavijam would you mind taking a look at it? Thanks, thanks and thanks! |
@@ -69,7 +69,6 @@ def render_auth_users_data(user, referrer, subdomain, referrer_organization_user | |||
email: user.email, | |||
organization: Carto::Api::OrganizationPresenter.new(user.organization).to_poro, | |||
base_url: user.public_url, | |||
feature_flags: user.feature_flag_names |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh! why?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ping @Kartones
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Part of this PR is removing this temporary hack and this line was added then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No idea :/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you checked everything is working properly? If so 👍.
And, have you checked google basemaps (under google_maps flag) are working properly? |
Yes! Google basemaps work 👍 |
In that case 🇬🇧 |
Thanks @xavijam! |
Frontend tests were OK 👍 (details) |
Frontend tests were OK 👍 (details) |
Frontend tests were OK 👍 (details) |
Frontend tests were OK 👍 (details) |
No description provided.