Prevent polling requests from being queued up #4980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… should be invoked on every cycle
…nfiguration for each type of model
alonsogarciapablo
changed the title
|
Frontend tests were OK 👍 (details) |
| return model.hasFailed() || model.hasCompleted(); | ||
| }, | ||
| error: function() { | ||
| this.model.trigger("change"); |
There was a problem hiding this comment.
what's the reason for using this.model and not just model, like done in condition fn above?
There was a problem hiding this comment.
Good catch! I thought about this but then forgot to revisit it. There's no specific reason.
I will also pass model to the error callback so that there's no need to know about the internals of the Poller:
...
error: function(model) {
model.trigger("change");
}
...
|
Apart from comments it LGTM 👍 |
alonsogarciapablo
added a commit
that referenced
this pull request
Aug 12, 2015
Prevent polling requests from being queued up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4939.
I've basically extracted some of the polling logic from
GeocodingModelandImportModelintoGeocodingModelPollerandImportModelPoller, which are specifications of a genericPoller. Instead of using an interval to triggerfetchrequests periodically, pollers now wait for the previous request to be received before triggering new ones :)@viddo could please take a look? I'm looking forward for your feedback! Thanks!