Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent polling requests from being queued up #4980

Merged
merged 23 commits into from
Aug 12, 2015
Merged

Prevent polling requests from being queued up #4980

merged 23 commits into from
Aug 12, 2015

Commits on Aug 10, 2015

  1. Do not poll until previous requests have been received

    @alonsogarciapablo
    alonsogarciapablo committed Aug 10, 2015
    Configuration menu
    Copy the full SHA
    8d51660 View commit details
    Browse the repository at this point in the history

  2. Revert to using an interval with a boolean flag to determine if fetch… 

    … should be invoked on every cycle
    @alonsogarciapablo
    alonsogarciapablo committed Aug 10, 2015
    Configuration menu
    Copy the full SHA
    c928303 View commit details
    Browse the repository at this point in the history

  3. Typo

    @alonsogarciapablo
    alonsogarciapablo committed Aug 10, 2015
    Configuration menu
    Copy the full SHA
    316c42c View commit details
    Browse the repository at this point in the history

  4. Extracted Poller class

    @alonsogarciapablo
    alonsogarciapablo committed Aug 10, 2015
    Configuration menu
    Copy the full SHA
    106c085 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2015

  1. Extracted tests for Poller

    @alonsogarciapablo
    alonsogarciapablo committed Aug 11, 2015
    Configuration menu
    Copy the full SHA
    22f071a View commit details
    Browse the repository at this point in the history

  2. Added autoStart option to the Poller

    @alonsogarciapablo
    alonsogarciapablo committed Aug 11, 2015
    Configuration menu
    Copy the full SHA
    bdf95d0 View commit details
    Browse the repository at this point in the history

  3. Poller needs to be instantiated before polling can actually happen

    @alonsogarciapablo
    alonsogarciapablo committed Aug 11, 2015
    Configuration menu
    Copy the full SHA
    cce5ac4 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/master' into 4939-better-polling

    @alonsogarciapablo
    alonsogarciapablo committed Aug 11, 2015
    Configuration menu
    Copy the full SHA
    2c4868e View commit details
    Browse the repository at this point in the history

  5. Poller accepts a function to specify a variable interval

    @alonsogarciapablo
    alonsogarciapablo committed Aug 11, 2015
    Configuration menu
    Copy the full SHA
    356141b View commit details
    Browse the repository at this point in the history

  6. ImportModel uses Poller to poll the model

    @alonsogarciapablo
    alonsogarciapablo committed Aug 11, 2015
    Configuration menu
    Copy the full SHA
    4be9e0a View commit details
    Browse the repository at this point in the history

  7. Renamed instance variable

    @alonsogarciapablo
    alonsogarciapablo committed Aug 11, 2015
    Configuration menu
    Copy the full SHA
    5074c0e View commit details
    Browse the repository at this point in the history

  8. condition shouldn't determine when to incremente the number of requ… 

    …ests
    @alonsogarciapablo
    alonsogarciapablo committed Aug 11, 2015
    Configuration menu
    Copy the full SHA
    8f10696 View commit details
    Browse the repository at this point in the history

  9. Tests

    @alonsogarciapablo
    alonsogarciapablo committed Aug 11, 2015
    Configuration menu
    Copy the full SHA
    ce9aa71 View commit details
    Browse the repository at this point in the history

  10. Fix test

    @alonsogarciapablo
    alonsogarciapablo committed Aug 11, 2015
    Configuration menu
    Copy the full SHA
    0066cb1 View commit details
    Browse the repository at this point in the history

  11. Fixed false positives and try to fix jasmine timeout

    @alonsogarciapablo
    alonsogarciapablo committed Aug 11, 2015
    Configuration menu
    Copy the full SHA
    5d064c2 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2015

  1. Created a GeocodingModelPoller and ImportModelPoller with specific co… 

    …nfiguration for each type of model
    @alonsogarciapablo
    alonsogarciapablo committed Aug 12, 2015
    Configuration menu
    Copy the full SHA
    c2d18b3 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into 4939-better-polling

    @alonsogarciapablo
    alonsogarciapablo committed Aug 12, 2015
    Configuration menu
    Copy the full SHA
    e9db1c8 View commit details
    Browse the repository at this point in the history

  3. Error callback receives the model as a parameter

    @alonsogarciapablo
    alonsogarciapablo committed Aug 12, 2015
    Configuration menu
    Copy the full SHA
    ecc6e00 View commit details
    Browse the repository at this point in the history

  4. Whitespace

    @alonsogarciapablo
    alonsogarciapablo committed Aug 12, 2015
    Configuration menu
    Copy the full SHA
    c92bee4 View commit details
    Browse the repository at this point in the history

  5. Tried to make condition a bit more clear

    @alonsogarciapablo
    alonsogarciapablo committed Aug 12, 2015
    Configuration menu
    Copy the full SHA
    e23a4a3 View commit details
    Browse the repository at this point in the history

  6. Renamed "condition" option to "stopWhen"

    @alonsogarciapablo
    alonsogarciapablo committed Aug 12, 2015
    Configuration menu
    Copy the full SHA
    e077782 View commit details
    Browse the repository at this point in the history

  7. Fixed test

    @alonsogarciapablo
    alonsogarciapablo committed Aug 12, 2015
    Configuration menu
    Copy the full SHA
    22d8980 View commit details
    Browse the repository at this point in the history

  8. Merge remote-tracking branch 'origin/master' into 4939-better-polling

    @alonsogarciapablo
    alonsogarciapablo committed Aug 12, 2015
    Configuration menu
    Copy the full SHA
    c9406db View commit details
    Browse the repository at this point in the history