Remove old, unused modals code

NEWS.md

@@ -50,6 +50,7 @@ cd lib/sql; sudo make all install
 * Added new fields source, attributions, and license, to metadata modal [#5016](https://github.com/CartoDB/cartodb/pull/5016)
 * Code related to pecan extracted to separate module [#4999](https://github.com/CartoDB/cartodb/pull/4999)
   * requires a `npm install` for grunt tasks
+* New modals [#5068](https://github.com/CartoDB/cartodb/pull/5068)
 
 Bugfixes:
 * Fixed deletion of layers upon disconnecting synced datasources [#3718](https://github.com/CartoDB/cartodb/pull/3718)

app/assets/stylesheets/common/create/listing/import_selected_dataset.css.scss

@@ -71,6 +71,9 @@ $br: 4px;
   @include display-flex();
   @include align-items(center, center);
 }
+.DatasetSelected-syncOptionsList--syncView {
+  margin-left: auto;
+}
 .DatasetSelected-syncOptionsItem { margin-left: 24px }
 .DatasetSelected-syncOptionsItem .RadioButton-label { font-size: $sFontSize-normal }
 .UpgradeElement.DatasetSelected-upgrade {

app/assets/stylesheets/common/dialog.css.scss

@@ -2,6 +2,8 @@
 @import "../variables/colors";
 @import "../variables/sizes";
 
+$sSmallWidth: 670px;
+
 /* set by base dialog */
 body.is-inDialog {
   overflow: hidden;
@@ -103,6 +105,9 @@ body.is-inDialog {
   padding-bottom: 0;
   overflow: auto;
 }
+.Dialog-body.Dialog-body--small {
+  width: $sSmallWidth;
+}
 .Dialog-Stretcher {
   width: $sLayout-width;
   @include display-flex();
@@ -132,6 +137,9 @@ body.is-inDialog {
   @include display-flex();
   @include justify-content(center);
 }
+.Dialog-footer--small {
+  width: $sSmallWidth;
+}
 .Dialog-footerContent {
   @include display-flex();
   @include justify-content(center);
@@ -221,6 +229,9 @@ body.is-inDialog {
   white-space: nowrap;
   overflow: hidden;
 }
+.Dialog-headerText--small {
+  width: $sSmallWidth;
+}
 .Dialog-footerBtn {
   margin-right: $sMargin-element;
 }

app/assets/stylesheets/common/icons/illustration-icon.css.scss

@@ -1,6 +1,7 @@
 @import "../../variables/mixins";
 @import "../../variables/colors";
 @import "../../variables/sizes";
+@import "../../map/map-sprite";
 
 $cNeutral:  $cHighlight-main;
 $cPositive: $cHighlight-positive;
@@ -42,6 +43,16 @@ $cLingon:     rgba(#AC638B, 1);
 .IllustrationIcon--royalDark { background-color: $cRoyalDark }
 .IllustrationIcon--magenta { background-color: $cMagenta }
 .IllustrationIcon--lingon { background-color: $cLingon }
+.IllustrationIcon--geometryLine {
+  @include map-sprite(geometry_line);
+}
+.IllustrationIcon--geometryPoint {
+  @include map-sprite(geometry_point);
+}
+.IllustrationIcon--geometryPolygon {
+  @include map-sprite(geometry_polygon);
+}
+
 
 .IllustrationIcon-text {
   font-size: $sFontSize-smallUpperCase;

app/assets/stylesheets/common/notifications-dropdown.css.scss

@@ -25,7 +25,7 @@
   border: 1px solid $cTypography-help;
   border-radius: 20px;
   font-size: $sFontSize-small;
-  line-height: $sLineHeight-small;
+  line-height: 17px;
   color: $cTypography-help;
   text-align: center;
 }
@@ -60,7 +60,7 @@
   @include align-items(center, center);
   background: none;
 }
-.NotificationsList-item.is--new {
+.NotificationsList-item.is-new {
   margin: 0 $sMargin-element $sMargin-element!important;
   padding: $sMargin-element 0 0 33px!important;
   border-top: 1px solid $cStructure-mainLine;
@@ -73,62 +73,19 @@
   }
 }
 
-// Custom icons for different messages
-.NotificationsList-item .iconFont-trial_ends_soon,
-.NotificationsList-item .iconFont-custom {
-  line-height: 17px;
-  &:before { content: "\E001" } 
-}
-.NotificationsList-item.is--new .iconFont-trial_ends_soon,
-.NotificationsList-item.is--new .iconFont-custom {
+.NotificationsList-item.is-new .NotificationsList-itemIcon--alert {
   color: $cHighlight-alert;
   border-color: $cHighlight-alert;
 }
-.NotificationsList-item .iconFont-upgraded_message {
-  line-height: 17px;
-  &:before { content: "\E004" }
-}
-.NotificationsList-item.is--new .iconFont-upgraded_message {
-  color: $cHighlight-positive;
-  border-color: $cHighlight-positive;
-}
-.NotificationsList-item .iconFont-try_trial {
-  line-height: 17px;
-  &:before { content: "\E035" } 
-}
-.NotificationsList-item.is--new .iconFont-try_trial {
+.NotificationsList-item.is-new .NotificationsList-itemIcon--positive {
   color: $cHighlight-positive;
   border-color: $cHighlight-positive;
 }
-.NotificationsList-item .iconFont-close_limits {
-  line-height: 17px;
-  &:before { content: "\E02D" } 
-}
-.NotificationsList-item.is--new .iconFont-close_limits {
-  color: $cHighlight-alert;
-  border-color: $cHighlight-alert;
-}
-.NotificationsList-item .iconFont-limits_exceeded {
-  line-height: 17px;
-  &:before { content: "\E036" } 
-}
-.NotificationsList-item.is--new .iconFont-limits_exceeded {
+.NotificationsList-item.is-new .NotificationsList-itemIcon--negative {
   color: $cHighlight-negative;
   border-color: $cHighlight-negative;
 }
-.NotificationsList-item .iconFont-new_dashboard { 
-  line-height: 17px;
-  &:before { content: "\E016" } 
-}
-.NotificationsList-item.is--new .iconFont-new_dashboard {
+.NotificationsList-item.is-new .NotificationsList-itemIcon--main {
   color: $cHighlight-main;
   border-color: $cHighlight-main;
 }
-.NotificationsList-item .iconFont-new_public_dashboard {
-  line-height: 17px;
-  &:before { content: "\E008" }
-}
-.NotificationsList-item.is--new .iconFont-new_public_dashboard {
-  color: $cHighlight-positive;
-  border-color: $cHighlight-positive;
-}

app/assets/stylesheets/editor/table_overrides.css.scss

@@ -21,17 +21,11 @@ div.vis_navigation nav a.tab {
   padding-bottom: 3px;
   font-weight: $sFontWeight-bold
 }
-.metadata_dialog label {
-  margin: 0;
-  margin-bottom: 7px;
-}
 
 div.table table tbody tr td div.cell,
 div.map .option-button,
 div.dropdown ul li a,
 .select2-results .select2-result-label,
-.metadata_dialog label,
-.metadata_dialog .hint,
 .form_spinner,
 .infowindow_panel .fields li .switches,
 .infowindow_panel .fields li.drag_field {
@@ -46,5 +40,5 @@ div.legends_panel div.forms.panel_content .right .checkbox { margin-top:11px; li
 .Dialog-headerTitle,
 .Dialog-headerText,
 .IntermediateInfo-title {
-  font-family: 'Lato', sans-serif; // TODO: remove when old styles are deleted  
+  font-family: 'Lato', sans-serif; // TODO: remove when old styles are deleted
 }

app/assets/stylesheets/map/map.css.scss

@@ -82,7 +82,7 @@ div.map {
 
       @include border-radius(0);
 
-      .cartodb-logo { 
+      .cartodb-logo {
         margin-bottom: 0px;
         bottom: 10px!important;
       }
@@ -471,7 +471,7 @@ div.map {
 
   }
 
-  div.cartodb-layer-selector-box { 
+  div.cartodb-layer-selector-box {
     display:none;
     font-weight: normal;
     margin: 0;
@@ -497,7 +497,7 @@ div.map {
     }
   }
 
-  // Fullscreen 
+  // Fullscreen
   div.cartodb-fullscreen {
     display:none;
     position:absolute;
@@ -691,38 +691,7 @@ div.map {
 
 } // div.cartodb-map
 
-section.block.noGeoRef {
-  background-color: #FFF0C1;
-  padding: 5px;
-
-  .innerBlock {
-    background-color: white;
-
-    .content {
-      color: #666;
-      line-height:120%;
-    }
-
-    .foot {
-      border-top: 0;
-      padding-top: 0px;
-
-      .cancel {
-        margin-top: 15px;
-
-        a { text-decoration: underline; }
-
-      }
-    }
-
-    .enabled { display: block; }
-
-  } // .innerBlock
-
-} // section.bloc.noGeoRef
-
 /* FOOTER EDIT BUTTONS  for infowindow */
-
 @mixin edit-bottom-states($x,$y,$c1,$c2,$c3,$c4) {
   @include background(sprite($map-sprites, infowindow-edit-tools, $offset-x: $x, $offset-y: $y) no-repeat, $c1); // IE
   @include background(sprite($map-sprites, infowindow-edit-tools, $offset-x: $x, $offset-y: $y) no-repeat, linear-gradient($c1,$c2) 0 0);
@@ -866,17 +835,15 @@ div.cartodb-edit-buttons {
   border:1px solid #397DBA;
 }
 
-:-webkit-full-screen { 
+:-webkit-full-screen {
   top: 0!Important; left: 0!Important; right: 0!Important; bottom: 0!Important;
 }
-:-moz-full-screen { 
+:-moz-full-screen {
   top: 0!Important; left: 0!Important; right: 0!Important; bottom: 0!Important;
 }
-:-ms-fullscreen { 
+:-ms-fullscreen {
   top: 0!Important; left: 0!Important; right: 0!Important; bottom: 0!Important;
 }
-:fullscreen { 
+:fullscreen {
   top: 0!Important; left: 0!Important; right: 0!Important; bottom: 0!Important;
 }
-
-