Remove old, unused modals code

[viddo]

Fixes #4673

This 🔥 🔥 🔥 code related to the now deprecated old modals.

Also removes a lot of implicit CSS, images, templates, models, views etc. that are no longer used.

Also saw some things that possibly could be removed too:

• OauthController / front_layout , the only usage of old_common.css bundle, is this layout even used anymore? How can we verify that? If not, I'd suggest to 🔥 it and remove unncessary old_common styles.
• fonts_ie.css.scss, really necessary anymore? Only used on public pages for some reason
• is the ProximaNova still required?
• considering old_common is getting phased out in favour of new styles, why not replace the submodule dir with a copy, so we can remove files easier as going forward? e.g. old_common/upload.css is no longer used
• old_elements/views/dialog_base - references from inside cartodb.js makes it impossible to remove this form now, used for ui/common/share.js view, is it really required for anything outside of cartodb? If not I'd suggest to move related code inside cartodb boundary and keep cartodb.js a little bit cleaner

@xavijam can you review?
cc @CartoDB/frontend + regarding the questions listed ☝️

[viddo]

cc @iriberri we'll probably need to do a smoke test on this one. in theory, it's only code related to old modals, but considering the amount of removed code better to be on the safe side.

[xavijam]

No more sprites please, let's try to leave and they are and if we need images, create them separately.

[viddo]

This was migrated from app/assets/stylesheets/map/scratch_dialog.css.scss (now deleted) as it was. cc @javierarce

, let's try to leave and they are and if we need images

Not sure I understand the sentence entirely, do we leave it as it is for now or you want to change it? What would be the proper way of writing these rules?

[xavijam]

Leave compass sprites as they are because we are still using it in the editor, but we shouldn't add more icons to them due to the fact that we will remove them when we have the new editor layout.

[xavijam]

I've checked that we have two modernizr files in vendor/assets/javascripts/...
Could we use just one and remove the other?

[xavijam]

Questions:

1. Do we use respond.js? I've searched through the repository and I didn't find anything.
2. Do we use spin.min.js? I feel, after this pull request, we are not using it anymore.

cc @CartoDB/frontend

[xavijam]

Seems like we forgot to remove old geocoding model, in table.js:

...
// TODO: remove when new_modals is enabled for everybody
this.geocoder = new cdb.admin.Geocoding();
...

And of course, their bindings, for example:

// Geocoder binding
this.options.geocoder.bind('geocodingComplete geocodingError geocodingCanceled', function() {
   this.notice(_t('loaded'));
}, this);
this.add_related_model(this.options.geocoder);

There are some of this type.

[xavijam]

In general terms, 🇺🇸, but it is difficult to evaluate the PR file by file. I encourage to pass all smoke tests related with editor view.

[viddo]

Geocoding is still used in table/header/options_menu.js, to check geocoder.isGeocoding(). I'll add it to the list of #5076 to consolidate those models too

[viddo]

1. Do we use respond.js? I've searched through the repository and I didn't find anything.

No, doesn't look like it, removing.

1. Do we use spin.min.js? I feel, after this pull request, we are not using it anymore.

It's still used in a handful of places (Search for new Spinner). Strangely enough, also used in cartodb.js: src/geo/ui/infowindow.js#L529, is it provided there or is some kind of implicit/hidden dependency for that view?

[iriberri]

Ping me if you need my help.