Enable edit metadata dialog when a SQL query is applied #5195
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4810.
This PR allows users to edit the metadata of a dataset when a SQL query has been applied. I have tried to apply a query like
SELECT 1
and editing the metadata seems to work fine. I wasn't here when this constraint was introduced so I'm not sure if there's any other situation when this might not work.@xavijam what do you think? thanks!