Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - helper examples #720

Merged
merged 17 commits into from
Jun 7, 2019
Merged

WIP - helper examples #720

merged 17 commits into from
Jun 7, 2019

Conversation

makella
Copy link
Contributor

@makella makella commented Jun 3, 2019

working on some basic examples of how to use the helper methods.

  • Part 1:

    • Description of each method and defaults
    • Examples of each one over different geometry and themes
    • Note about types of source layers
  • Part 2:

    • Customization parameters for each helper
    • Mulit-layer example
  • Basemaps and viewport

@makella
Copy link
Contributor Author

makella commented Jun 4, 2019

Ok! Here are helper method Part 1 and 2 example notebooks. Tagging @Jesus89 and @VictorVelarde for review since @elenatorro I know you are getting the workshop ready (but definitely want your feedback too)! Related to that, feel free to use any of the maps as screenshots for your helper methods section.

I know there are so many more examples to make and even ways to customize what I have here further (my mind is turning the wheels)... in the interest of keeping the focus on helper methods, I didn't go too crazy :).

@jorgesancha I will look at adding the multi-layer example tomorrow (I have an idea). Also, once the review is complete, I will see about a screencast and also please feel free to use these for your meeting with Virginia.

@Jesus89
Copy link
Member

Jesus89 commented Jun 4, 2019

This is awesome mamata ❤️

Nice to see real world examples using the new API 😄

Note1: I'm not sure about showing the _inspect method since this is something we use internally.
Note2: You are using 'table_name' for the source, but it actually works with any of the sources available (table_name, sql_query, geojson, etc)
Note3: You need to import the basemaps for the part-2 notebook (from cartoframes.viz import basemaps)

@makella
Copy link
Contributor Author

makella commented Jun 4, 2019

@Jesus89 yay!! thank you for your eyes on this!!

Note1: I'm not sure about showing the _inspect method since this is something we use internally.

oops forgot to delete! was an artifact from the original notebook i copied. thanks for pointing out!

Note2: You are using 'table_name' for the source, but it actually works with any of the sources available (table_name, sql_query, geojson, etc)

good point!! let me think about how to incorporate this

Note3: You need to import the basemaps for the part-2 notebook (from cartoframes.viz import basemaps)

ahhhh yessss... i had it in there but removed since the basemaps were drawing. will add that section back.

@VictorVelarde
Copy link
Contributor

VictorVelarde commented Jun 4, 2019

I'm not going to be able to give you feedback today nor tomorrow, so feel free to merge into develop if you wish and I'll try to have a look later on.

@makella
Copy link
Contributor Author

makella commented Jun 4, 2019

@VictorVelarde no worries!! i haven't had a chance to do @Jesus89 comments yet. but I'll ask him to review one more time then can merge.

@makella
Copy link
Contributor Author

makella commented Jun 4, 2019

  • Note1
  • Note2
  • Note3

" }\n",
"}\n",
"\n",
"const responsive = doc
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about passing palette='[red, blue]' (or whatever colors are usually used for GOP and DEM) instead of the default here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andy-esch as mentioned, that (and more!) come in part 2!

@makella makella requested a review from andy-esch June 5, 2019 19:27
@makella
Copy link
Contributor Author

makella commented Jun 5, 2019

@Jesus89 fixed all of your notes! Thanks for the review!! If you want, feel free to look over the Multi-layer section in Part 2 and the description of sources in the opening paragraphs of Part 1.

@jorgesancha Part 2 includes multi-layer examples! (Great idea to do that!)

@Jesus89
Copy link
Member

Jesus89 commented Jun 6, 2019

Hey, @makella it looks nice!

The content looks good to me, but I have an issue loading each notebook because it contains lots of maps. Maybe we could split the examples in different notebooks to improve the performance and the experience of the readers.

I have seen that there is a weird file examples/.ipynb to the PR. You can remove it and commit it to the PR.

@makella
Copy link
Contributor Author

makella commented Jun 6, 2019

@Jesus89 thanks! deleted that orphan file... in terms of performance and splitting content... let me look into that... i guess i can have a few different notebooks but will break each one's "flow". ugh. would like to move on from this but will see what i can do

@Jesus89
Copy link
Member

Jesus89 commented Jun 6, 2019

OK. No problem, this is just a suggestion. Keeping 2 notebooks is fine too

@makella
Copy link
Contributor Author

makella commented Jun 6, 2019

@Jesus89 totally but a really good point. I was thinking some of the viewport/basemap stuff could be moved to another notebook as well as the multi-layer example... let's see!

@makella
Copy link
Contributor Author

makella commented Jun 7, 2019

@Jesus89 ok, removed some maps from part 1 (i had multiple maps to demonstrate the same helper) also removed some extra stuff from part 2 and made the viewport/basemap customization a separate example.

thanks!

@makella makella merged commit 58bfc61 into develop Jun 7, 2019
@makella
Copy link
Contributor Author

makella commented Jun 7, 2019

merged!

@makella makella deleted the 0.10-examples branch June 7, 2019 13:52
@Jesus89 Jesus89 added this to the Release v0.11 milestone Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants