Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

734 fix dataset schema in develop #767

Closed
wants to merge 2 commits into from

Conversation

simon-contreras-deel
Copy link
Contributor

apply fix from #762 in develop

@Jesus89
Copy link
Member

Jesus89 commented Jun 12, 2019

Hi @oleurud.

Once we have the hotfix branch ready with all the fixes, we can create a PR to merge the hotfix branch into develop, so we bring everything here, also the NEWs, etc and we don't need to duplicate the work.

@simon-contreras-deel
Copy link
Contributor Author

I have done it because the same fix doesn't apply exactly. But ok, we can wait until that

@simon-contreras-deel simon-contreras-deel removed the request for review from alrocar June 12, 2019 09:35
@Jesus89
Copy link
Member

Jesus89 commented Jun 12, 2019

True that, but the merge conflicts could be solved when the hotfix branch is merged.

@Jesus89 Jesus89 closed this Jun 12, 2019
@Jesus89 Jesus89 deleted the 734-fix-dataset-schema-develop branch June 12, 2019 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants