Don't persist signature until after verification

Casa · Apr 29, 2021 · 5823317 · 5823317
1 parent 79ae7bf
commit 5823317
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/lib/primitives/mtx.js b/lib/primitives/mtx.js
@@ -721,12 +721,12 @@ class MTX extends TX {
 
       result.push(redeem);
 
-      vector.fromStack(result);
-
       if (preSig && this.checksig(index, prev, value, sig, ring.publicKey, version) === false) {
         throw new Error('Invalid signature.');
       }
 
+      vector.fromStack(result);
+
       return true;
     }
 
@@ -736,12 +736,12 @@ class MTX extends TX {
     if (!result)
       return false;
 
-    vector.fromStack(result);
-
     if (preSig && this.checksig(index, prev, value, sig, ring.publicKey, version) === false) {
       throw new Error('Invalid signature.');
     }
 
+    vector.fromStack(result);
+
     return true;
   }