Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make HyMD output valid HyMD input #79

Open
mortele opened this issue Apr 17, 2021 · 3 comments
Open

Make HyMD output valid HyMD input #79

mortele opened this issue Apr 17, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@mortele
Copy link
Member

mortele commented Apr 17, 2021

The extra step of converting it with the external script is getting tedious. I think we should allow output from the code to be used directly as input.

This would involve storing bonds in the output. Bond information is already stored in the output in the /parameters/vmd_structure/bond_from and /parameters/vmd_structure/bond_to datasets, but I am not writing a built-in parser back to the format we use internally (if someone else wants to, feel free). I would much rather just store an extra array of integers.

@mortele mortele added the enhancement New feature or request label Apr 17, 2021
@mortele
Copy link
Member Author

mortele commented Apr 17, 2021

There are some minor design decisions involved in this, such as: Do we make a new keyword in config to specify which frame to use as the starting point for the new simulation? I think in any case that it should default to the last frame.

@Lun4m
Copy link
Member

Lun4m commented May 12, 2021

I think we should """just""" rework the parser so that it only reads the H5MD format, without having to switch formats inside the code. But this will probably require a lot a work and might break stuff/create bugs.

@samiransen23
Copy link
Contributor

Are you still using h5md2input.py to extract the last(/specific) frame to convert it into an input.h5 to restart a simulation from there or have you already improved the method? @mortele

@mortele mortele moved this from To do to Done in Version 1.0 release Jan 7, 2022
@mortele mortele moved this from Done to To do in Version 1.0 release Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Development

No branches or pull requests

3 participants