RPC sidecar changes #231
Merged
RPC sidecar changes #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eparate binaries and `cargo build` will produce two executable packages. * Updating schemars version because the old one having bugs (if there is a name collision for components schema only one will be saved) * Copying casper_types to this project. The reason is that casper_types in release <= 4.0.1 depends on old schemars * Copying casper_types for 2.0 release to this project. The reason is that rpc sidecar has to use the new types definitions, but for now they are not released (and it's not clear if they will be released prior to node 2.0 release). * Changing RpcError implementation to fix tests. Some alignments of codestyle to make clippy happy. * Moving casper-types dependencies to workspace level
Sync changes from node branch
jacek-casper
requested review from
Fraser999,
EdHastingsCasperAssociation,
zajko and
alsrdn
Updates for the sidecar
Switch to having a single binary
bump 'juliet' to '0.2.1'
Sync casper-types changes
…ntial_backoff will take a new parameter called max_attempts. I tcan be either "infinite" or a positive, non-zero number.
Changing RPC sidecar config so that the rpc_server.node_client.expone…
…fig from DDLConfiguration because it's no longer needed (new version of sea_query handles the situation of defining big_integer and autoincrement)
Storing ApiVersion in event_log table. Removing is_big_integer_id con…
Revert "Storing ApiVersion in event_log table. Removing is_big_integer_id con…"
* Update for node changes * Fix lints * Cleanup * Cover all values in tag roundtrip tests
…arately from sse events server. Also the database initialization happens separetely. Is sse events server is defined a storage definition is required. If rest api server is defined a storage definition is required.
…rom_sse_server Moving API servers out of the SSE server
casperlabs-bors-ng bot
added a commit
to casper-network/casper-node
that referenced
this pull request
Feb 29, 2024
4491: RPC sidecar changes r=jacek-casper a=jacek-casper This PR includes: - addition of a TCP listener in the node that will be handling requests from the RPC sidecar - NCTL changes necessary to pull, build and run the sidecar alongside the nodes - a specification of the binary protocol - some changes to casper-types to expose types needed for the sidecar to work - removal of the existing RPC server The purpose of this PR is to get a high-level review, there are still minor changes being done and unit tests being added. PR for the addition of the sidecar: casper-network/casper-sidecar#231 Co-authored-by: Rafał Chabowski <rafal@casperlabs.io> Co-authored-by: Jacek Malec <145967538+jacek-casper@users.noreply.github.com>
casperlabs-bors-ng bot
added a commit
to casper-network/casper-node
that referenced
this pull request
Feb 29, 2024
4491: RPC sidecar changes r=jacek-casper a=jacek-casper This PR includes: - addition of a TCP listener in the node that will be handling requests from the RPC sidecar - NCTL changes necessary to pull, build and run the sidecar alongside the nodes - a specification of the binary protocol - some changes to casper-types to expose types needed for the sidecar to work - removal of the existing RPC server The purpose of this PR is to get a high-level review, there are still minor changes being done and unit tests being added. PR for the addition of the sidecar: casper-network/casper-sidecar#231 Co-authored-by: Rafał Chabowski <rafal@casperlabs.io> Co-authored-by: Jacek Malec <145967538+jacek-casper@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes:
The diff is very large because of the casper-types copies, which you can ignore, the relevant changes are in the
rpc-sidecarandsidecardirectories.PR for required node changes: casper-network/casper-node#4491