Update Top 5 JSON file #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elyezer
force-pushed
the
update-top5-json
branch
5 times, most recently
from
3450449
to
aad6ada
Compare
|
Looking good!!! |
elyezer
force-pushed
the
update-top5-json
branch
2 times, most recently
from
346780d
to
0977d62
Compare
Do the following: * Improve `top5` directive to output a numerated list instead of a bullet list. * Fix a bug that the `top5best` was not showing the most suggested items first. * Update the `top5.json` with grep'ed items from all episodes * Convert 5 more episodes to make use of the `top5` directive
elyezer
force-pushed
the
update-top5-json
branch
from
0977d62
to
c4cda17
Compare
|
@omaciel I am glad you like it. This is now ready for review, I've updated PR title and description with everything done. After this I will send more PRs with more episodes converted to use the |
omaciel
approved these changes
Oct 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do the following:
top5directive to output a numerated list instead of a bulletlist.
top5bestwas not showing the most suggested itemsfirst.
top5.jsonwith grep'ed items from all episodestop5directive