Return 404 from PUT /library/casts when the cast doesnt exist

api/casts.go

@@ -50,12 +50,14 @@ func renameCast(c *echo.Context) error {
 	}
 
 	cast := store.GetCast(id)
-	if cast != nil {
-		prev := cast.Name
-		cast.Name = form(c, "name")
-		if cast.Name != prev {
-			return store.SaveCast(cast)
-		}
+	if cast == nil {
+		return c.String(404, "Cast not found")
+	}
+
+	prev := cast.Name
+	cast.Name = form(c, "name")
+	if cast.Name != prev {
+		return store.SaveCast(cast)
 	}
 
 	return nil

api/casts_test.go

@@ -86,14 +86,16 @@ func TestRenameCast(t *testing.T) {
 	res := req.send()
 	assert.Equal(t, 200, res.Code)
 	assert.Equal(t, "new", store.GetCast(1).Name)
+	res = req.send()
+	assert.Equal(t, 200, res.Code)
 
 	// It should return 400 if the ID is invalid
 	req.URL.Path = "/library/casts/nope"
 	assert.Equal(t, 400, req.send().Code)
 
-	// It returns 200 if the cast is not found
+	// It returns 404 if the cast is not found
 	req.URL.Path = "/library/casts/1337"
-	assert.Equal(t, 200, req.send().Code)
+	assert.Equal(t, 404, req.send().Code)
 }
 
 func TestRemoveCast(t *testing.T) {