Dont use redis inside the workers (#113)

Co-authored-by: Niek Candaele <22315101+niekcandaele@users.noreply.github.com>
CatalysmsServerManager · Jun 11, 2020 · d3b0208 · d3b0208
1 parent 354bdbb
commit d3b0208
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 30 deletions.
diff --git a/api/hooks/sdtdLogs/LoggingObject.js b/api/hooks/sdtdLogs/LoggingObject.js
@@ -55,7 +55,6 @@ class LoggingObject extends EventEmitter {
   };
 
   async init(ms = sails.config.custom.logCheckInterval) {
-
     if (!ms) {
       ms = 3000;
     }
@@ -91,7 +90,6 @@ class LoggingObject extends EventEmitter {
       result = JSON.parse(result);
     }
 
-
     if (result.serverId.toString() !== this.serverId) {
       // not one of ours
       return;
@@ -128,6 +126,7 @@ class LoggingObject extends EventEmitter {
     }
 
     await this.setFailedToZero();
+    await this.setLastLogLine(result.lastLogLine);
     await this.addFetchJob();
   }
 
@@ -153,14 +152,17 @@ class LoggingObject extends EventEmitter {
     );
   }
 
-  async setLastLogLine() {
+  async setLastLogLine(lastLogLine) {
     const server = await SdtdServer.findOne(this.serverId)
-    const webUIUpdate = await SdtdApi.getWebUIUpdates(SdtdServer.getAPIConfig(server));
-    const lastLogLine = parseInt(webUIUpdate.newlogs) + 1;
+    if (!lastLogLine && lastLogLine !== 0) {
+      const webUIUpdate = await SdtdApi.getWebUIUpdates(SdtdServer.getAPIConfig(server));
+      lastLogLine = parseInt(webUIUpdate.newlogs) + 1;
+    }
     await sails.helpers.redis.set(
       `sdtdserver:${this.serverId}:sdtdLogs:lastLogLine`,
       lastLogLine
     );
+    this.lastLogLine = lastLogLine;
     this.emptyResponses = 0;
     return lastLogLine;
   }

diff --git a/api/hooks/sdtdLogs/logProcessor.js b/api/hooks/sdtdLogs/logProcessor.js
@@ -3,13 +3,7 @@ const handleLogLine = require("./handleLogLine");
 
 module.exports = async function(job) {
   const resultLogs = [];
-  // Get latest log line from Redis
-  let lastLogLine = parseInt(
-    await sails.helpers.redis.get(
-      `sdtdserver:${job.data.server.id}:sdtdLogs:lastLogLine`
-    )
-  );
-
+  let lastLogLine = job.data.lastLogLine;
   // If latest log line is not found, get it from the server
   if (!lastLogLine) {
     const webUIUpdate = await sails.helpers.sdtdApi.getWebUIUpdates(SdtdServer.getAPIConfig(job.data.server));
@@ -22,12 +16,6 @@ module.exports = async function(job) {
   // Adjust latest log line based on new logs we got
   lastLogLine = lastLogLine + newLogs.entries.length;
 
-  // Set latest log line in Redis
-  await sails.helpers.redis.set(
-    `sdtdserver:${job.data.server.id}:sdtdLogs:lastLogLine`,
-    lastLogLine
-  );
-
   // Parse these logs into usable data
   let index = -1;
   for (const line of newLogs.entries) {
@@ -46,12 +34,6 @@ module.exports = async function(job) {
     }
   }
 
-  // Set last success date in Redis
-  await sails.helpers.redis.set(
-    `sdtdserver:${job.data.server.id}:sdtdLogs:lastSuccess`,
-    Date.now()
-  );
-
   return Promise.resolve({
     serverId: job.data.server.id,
     lastLogLine,

diff --git a/test/integration/cron-job/cron.test.js b/test/integration/cron-job/cron.test.js
@@ -3,16 +3,16 @@ var expect = require("chai").expect;
 
 describe('POST /api/sdtdserver/cron', function () {
 
-  it('should return 200 with valid info', function (done) {
-    supertest(sails.hooks.http.app)
+  it('should return 200 with valid info', async function () {
+    const response = await supertest(sails.hooks.http.app)
       .post('/api/sdtdserver/cron')
       .send({
         serverId: 1,
         command: 'help',
         temporalValue: '0 */6 * * *'
       })
-      .expect('Content-Type', /json/)
-      .expect(200, done);
+    expect(response.statusCode).to.be.eql(200);
+    expect(response.header['content-type']).to.include('json');
   });
   it('should return 400 when command or temporal value is not given', function (done) {
     supertest(sails.hooks.http.app)

diff --git a/test/integration/hooks/sdtdLogs/logProcessor.test.js b/test/integration/hooks/sdtdLogs/logProcessor.test.js
@@ -4,10 +4,9 @@ const logProcessor = require("../../../../api/hooks/sdtdLogs/logProcessor");
 
 describe('logProcessor', function () {
   it('Confirm able to fetch log messages', async function () {
-    sails.cache[`sdtdserver:${sails.testServer.id}:sdtdLogs:lastLogLine`] = 1100;
     sinon.stub(sails.helpers.sdtdApi, "getWebUIUpdates").callsFake(async function () {
       return {
-        newlogs: 1100
+        newlogs: 1099
       }
     });
     sinon.stub(sails.helpers.sdtdApi, "getLog").callsFake(async function () {