Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lookup and player command erroring out #230

Closed
niekcandaele opened this issue Aug 1, 2020 · 0 comments
Closed

lookup and player command erroring out #230

niekcandaele opened this issue Aug 1, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@niekcandaele
Copy link
Member

Describe the bug
The lookup and player Discord commands don't work properly

From my limited research, I belive the problem is here
https://github.com/CatalysmsServerManager/7-days-to-die-server-manager/blob/master/api/hooks/discordBot/commands/sdtd/lookup.js#L86

Not confirmed or anything..

image

@niekcandaele niekcandaele added the bug Something isn't working label Aug 1, 2020
halkeye added a commit to halkeye/7-days-to-die-server-manager that referenced this issue Aug 2, 2020
The problem is that
https://7dtd.illy.bz/browser/binary-improvements/MapRendering/Web/API/GetPlayerList.cs#L28
returns 25 players by default. The code assumes the user will be in the
list of players. Sadly the machinepack library doesn't let you specify
more anyways. Plus I don't think it actually matters since its really
just grabbing a list of players, and it'll return the most recent 25
users.

So if someone is looking up an older user, we already know we have the
db version and its unlikely changed. So return the db version when it
cant find the return from the server.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant