Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop on death value is reported incorrectly for serverinfo command #171

Merged
merged 1 commit into from
Jul 14, 2020

Conversation

niekcandaele
Copy link
Member

Fixes #167

@codeclimate
Copy link

codeclimate bot commented Jul 14, 2020

Code Climate has analyzed commit 65c9255 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 0.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 21.0% (0.0% change).

View more on Code Climate.

@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@38ec018). Click here to learn what that means.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #171   +/-   ##
=========================================
  Coverage          ?   21.08%           
=========================================
  Files             ?      395           
  Lines             ?     6198           
  Branches          ?        0           
=========================================
  Hits              ?     1307           
  Misses            ?     4891           
  Partials          ?        0           
Impacted Files Coverage Δ
api/hooks/discordBot/commands/sdtd/serverInfo.js 9.30% <0.00%> (ø)
api/helpers/sdtd/load-player-stats.js 4.54% <0.00%> (ø)
...ks/discordNotifications/notifications/connected.js 42.85% <0.00%> (ø)
api/models/PlayerUsedGimme.js 100.00% <0.00%> (ø)
api/policies/isLoggedIn.js 14.28% <0.00%> (ø)
api/controllers/Shop/listing-edit.js 4.54% <0.00%> (ø)
api/controllers/BannedItemList/get-banned-items.js 100.00% <0.00%> (ø)
api/controllers/player-teleport/get-teleports.js 83.33% <0.00%> (ø)
api/controllers/SdtdServer/commands/get-prefix.js 33.33% <0.00%> (ø)
api/hooks/discordBot/commands/sdtd/lookup.js 12.19% <0.00%> (ø)
... and 386 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38ec018...65c9255. Read the comment docs.

@niekcandaele niekcandaele merged commit 7931dac into master Jul 14, 2020
@niekcandaele niekcandaele deleted the niekcandaele/issue167 branch July 14, 2020 19:42
@niekcandaele niekcandaele added the bug Something isn't working label Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop on death value is reported incorrectly for serverinfo command
2 participants