Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug/emit events for all built in events #79

Merged
merged 2 commits into from
May 3, 2020

Conversation

niekcandaele
Copy link
Member

No description provided.

@codeclimate
Copy link

codeclimate bot commented May 3, 2020

Code Climate has analyzed commit 48fcf00 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 50.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 24.9% (0.0% change).

View more on Code Climate.

@codecov-io
Copy link

codecov-io commented May 3, 2020

Codecov Report

Merging #79 into master will decrease coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #79      +/-   ##
==========================================
- Coverage   24.91%   24.90%   -0.01%     
==========================================
  Files         405      405              
  Lines        6712     6713       +1     
==========================================
  Hits         1672     1672              
- Misses       5040     5041       +1     
Impacted Files Coverage Δ
api/hooks/sdtdLogs/LoggingObject.js 32.53% <50.00%> (-0.40%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b07651e...48fcf00. Read the comment docs.

@niekcandaele niekcandaele merged commit 7497788 into master May 3, 2020
@niekcandaele niekcandaele deleted the bug/emit-events-for-all-built-in-events branch May 3, 2020 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants