Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker build needs a proper healthcheck #84

Merged
merged 2 commits into from
May 9, 2020
Merged

Conversation

niekcandaele
Copy link
Member

Fixes #83

@codecov-io
Copy link

codecov-io commented May 9, 2020

Codecov Report

Merging #84 into master will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #84      +/-   ##
==========================================
- Coverage   18.45%   18.41%   -0.04%     
==========================================
  Files         389      390       +1     
  Lines        6195     6206      +11     
==========================================
  Hits         1143     1143              
- Misses       5052     5063      +11     
Impacted Files Coverage Δ
scripts/healthcheck.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcc67d6...d833a05. Read the comment docs.

@codeclimate
Copy link

codeclimate bot commented May 9, 2020

Code Climate has analyzed commit d833a05 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 0.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 18.4% (0.0% change).

View more on Code Climate.

@niekcandaele niekcandaele merged commit ee1d4ec into master May 9, 2020
@niekcandaele niekcandaele deleted the niekcandaele/issue83 branch May 9, 2020 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker build needs a proper healthcheck
2 participants