Skip to content
This repository has been archived by the owner. It is now read-only.

Add a default/dummy bounding box on site setup #234

Merged
merged 1 commit into from Nov 28, 2017

Conversation

Projects
None yet
2 participants
@c-w
Copy link
Member

commented Nov 27, 2017

For more background on this change, please refer to the discussion in #233

@Smarker: Do you see any concerns for this change from an admin/editing perspective? It should be possible to edit the dummy bounding box after the deployment is finished, right?

@erikschlegel: Any objections to this change?

@c-w c-w requested review from Smarker and erikschlegel Nov 27, 2017

@Smarker

This comment has been minimized.

Copy link
Contributor

commented Nov 27, 2017

This change looks good. A small change on the UI would be needed, so that you can edit the bbox. I don't think any service change would be necessary.

It seems like we'd need to add an input field for geofence/bounding box, since I don't think this is editable via admin sitesettings. I think it would just be a matter of adding another input field like the one here

We already have the bbox value saved here.

When you save site settings, save_settings will be called, which calls editSite. EditSite can already change this bbox value.

@Smarker
Copy link
Contributor

left a comment

LGTM - we would need to edit the admin sitesettings react component and add an input field, so that the user can edit the bbox.

@c-w c-w merged commit ffa0c3f into master Nov 28, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@c-w c-w deleted the fix-site-load branch Nov 28, 2017

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.