add (optional, configurable) back button in details view, add state-service #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i don't understand the necessity for this, especially the directive all it has to do is call a real browser back, the way it works now it actually creates a new history entry and i can reverse the back action by clicking the browser back button i'm not really inclined to include this into the base-code without a very good reason 👎 |
|
in addition: have a look at http://christopherthielen.github.io/ui-router-extras/#/previous |
|
I will investigate, why we did it this way... |
mangei
force-pushed
the
MG/stateService
branch
3 times, most recently
from
981106d
to
8fff593
Compare
mangei
force-pushed
the
MG/stateService
branch
from
8fff593
to
6b40078
Compare
|
closing for now, if there really is an compelling reason for such a feature open an appropriate ticket |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.