-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(playground): added more playground examples #524
base: master
Are you sure you want to change the base?
feat(playground): added more playground examples #524
Conversation
return { | ||
data: dataSet['date'], | ||
dailyconfirmed: dataSet['dailyconfirmed'], | ||
dailydeceased: dataSet['dailydeceased'], | ||
dailyrecovered: dataSet['dailyrecovered'] | ||
} | ||
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's fix the indentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also return
is not needed here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This mapping is essentially picking keys from objects. Shall we change key names to make this a little more exciting?
@@ -12,4 +13,32 @@ export const customResources: Resources = { | |||
return "Hi, this is AskQL server! It's " + new Date().toString(); | |||
}, | |||
}), | |||
statewise: resource({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make this custom resource name more specific
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding more examples @YonatanKra.
All of those are currently using fetch
and map
maybe we can use add filter
to some of them to make them more interesting?
Closes #181