Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/groups #71

Merged
merged 22 commits into from
Nov 6, 2020
Merged

Feature/groups #71

merged 22 commits into from
Nov 6, 2020

Conversation

TheLastProject
Copy link
Member

@TheLastProject TheLastProject commented Oct 25, 2020

Group management:

  • Create groups
  • Rename groups
  • Delete groups

Card management:

  • View groups (in edit view)
  • Edit groups

Import/export

  • Import/export groups with cards

Filtering:

  • Group filtering

Unit testing:

  • Create group
  • Rename group
  • Delete group
  • View groups of card
  • Edit groups of card
  • Group filtering
  • Hiding of group options if no groups exist
  • Import/export

@TheLastProject TheLastProject linked an issue Oct 25, 2020 that may be closed by this pull request
@TheLastProject
Copy link
Member Author

This seems done now. I've been looking at your code all the time @arshbeerSingh, feel free to look at my code and tell me if you have any opinion (this feature took much longer to make than I expected so I've probably made some mistakes I can no longer properly see) :)

@arshbeerSingh
Copy link
Contributor

@TheLastProject thank you very much for giving me the opportunity to review your code.
I will go through your code and would provide suggestions (if any) that I think would be helpful

@TheLastProject
Copy link
Member Author

@arshbeerSingh Don't get me wrong with me merging this, you are still welcome to review, but I'd like to give translators a chance to translate and then get this out in a beta release :)

@TheLastProject TheLastProject merged commit 4bbeb27 into master Nov 6, 2020
@TheLastProject TheLastProject deleted the feature/groups branch November 6, 2020 17:12
@arshbeerSingh
Copy link
Contributor

@TheLastProject I understand. Sorry, I was not able to review your code or fix the assigned issues in the past few days as I was preparing for my school exams.

@TheLastProject
Copy link
Member Author

Exams are more important! Good luck with them!

@arshbeerSingh
Copy link
Contributor

Thank You very much @TheLastProject

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grouping of entries
2 participants